Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dynamically light particle config setting (To stop lag) #206

Closed
borisshoes opened this issue Jan 29, 2024 · 3 comments
Closed

Disable dynamically light particle config setting (To stop lag) #206

borisshoes opened this issue Jan 29, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@borisshoes
Copy link

Is your feature request related to a problem? Please describe the solution you'd like
It would be great if the config has a way to disable dynamic lighting for either all particles or have a list of configurable dynamic particles similar to the block and entity config list currently implemented.

Playing on servers that make use of a lot of particle effects for things like minigames can obliterate frames even with a decent graphics card (I use a GTX 1080).

Describe alternatives you've considered
Disabling particles is a bit of a non-starter since servers can force them to be displayed on decreased/minimal settings and they often provide key visuals in game modes.
I've also tried tweaking the current config settings to see if they affect the particle rendering.

Additional context
Here's a client spark profiler report just to verify that it is lamb's dynamic particle rendering that is causing the lag:

image

@borisshoes borisshoes added the enhancement New feature or request label Jan 29, 2024
@LambdAurora
Copy link
Owner

Due to how the injection is made I cannot selectively disable particles specifically.

But I plan on looking into optimizing light lookups.

@LambdAurora
Copy link
Owner

This issue should be heavily alleviated with LambDynamicLights 3.1.0 which contains new optimizations.

@borisshoes
Copy link
Author

Can confirm, the latest version fixes the lag problem! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants