Potential error in merit.cpp?

[RAIST5150]

A returning player on xiweb noticed they could no longer increase max merits any more today (hp/mp capped at 15, max merits at 23rd). My character has the HP/MP category fully capped (15/15/45).

Started poking around... if I am reading this right, somewhere along the way the HP/MP category got set to a cap of 45 instead of 75?

[TeoTwawki]

there is also a setting that affects this max storable merits, you may want to check that.

[TeoTwawki]

I'm not sure whats happening at your server, on mine the value in the settings is the base before spending to increase it in the category, and I went with 50 (20 more than modern retail). After players spend to increase it, it goes beyond 50.

Also it is possible to overflow what fits there (I used to have it much higher, before meriting your max merits became a thing - this turned into a problem after that change and I had to dial it back from the 99 I used to use)

[RAIST5150]

That appears to be functioning as intended... 30 initial as set in the main config files, plus what we extend it by merits.

What is in question is the category spending limits, which appear to be set up here in merit.cpp:

struct MeritCategoryInfo_t
{
    int8  MeritsInCat; // number of elements in a group
    uint8 MaxPoints;   // the maximum number of points that can be put into a group
    uint8 UpgradeID;   // group index in upgrade array
};

static const MeritCategoryInfo_t meritCatInfo[] = {
    { 3, 45, 0 },   // MCATEGORY_HP_MP       catNumber 00
    { 7, 105, 1 },  // MCATEGORY_ATTRIBUTES  catNumber 01
    { 19, 152, 2 }, // MCATEGORY_COMBAT      catNumber 02
    { 14, 112, 4 }, // MCATEGORY_MAGIC       catNumber 03
    { 5, 10, 5 },   // MCATEGORY_OTHERS      catNumber 04

Is it supposed to be 45 or 75? As at least two of us have spent past 45 in the past, but it appears now they cannot.

[TeoTwawki]

🤔
I read it as 45+30=75, so should say 45 there, but forgot that the hp/mp merits count against it too. you might be right. May have been overlooked in last refactor.

when I initially posted, I was thinking maybe something crazy was being used and it rolled over, or the setting got missed during one of the settings file changeovers. It didn't hit me that you are from Kain's server.

[TeoTwawki]

yeah, just did some quick experimenting on a fresh copy. needs 75.

[RAIST5150]

Addressed by Xaver with PR #3685 , closing discussion