A Moogle Kupo d'Etat

[Flibe-XI]

Hello, I'm new here to LSB, and I'm looking to start contributing in any way I can. Previously I implemented AMK on the wings codebase, and I'd like to help finish out that here if no one else is working on it. I've been a dev for about a year, and I've started acclimating myself to the LSB codebase. I've read through the contributing guidelines, but please let me know if anything I'm doing is incorrect.

I've made one PR already, regarding some incremental progress to AMK. I know that everyone has a lot going on, but if someone could take a look at it and tell me if I'm doing something wrong before I start working on the rest of the missions and find out someone else is already doing it or whatever.

If this is something I could work on, how should I go about making incremental progress while I wait for previous PRs to be reviewed and accepted? Do I keep submitting separate PRs in succession of each other? Or wait until one is merged, then submit the next one.

Any advice greatly appreciated.

[TeoTwawki]

It is going to take some time, each of us on the team has a few areas we're more familiar than the others on (its a biiiiig code base) and sometimes there is lack of familiarity with parts of the retail game - like I saw your PR but I know very little of AMK so its waiting for someone who's done work related to it previously or that knows it well to get a review started.

I would suggest taking your time, and if you want to do multiple PRs that is fine but make sure to use a separate branch so that the work in each doesn't get mixed - it can be very difficult on you if you accidently smush 2 pr's together.

Not that having to rebase can also be a challenge if you aren't familiar with doing that on the regular and you will definitely have to rebase a few of your pr's when you get some that touch the same files - whichever merges 1st will trip a conflict on the next. Once you get used to it it is not so bad.

[Flibe-XI]

Thank you for the advice! I can do that.

[MowFord]

It's tricky specifically for AMK since some of the missions overlap on file updates. Specifically, Tenshodo Coffer and Squintrox. Luckily those are already updated for all the mini expansions. Bad news is that we need to rebase the feature-amk branch to pull those changes in. I think someone from the LSB team wanted to do that part of it, but once it's rebased I don't see an issue with creating multiple PRs for AMK that live side by side (different local branch for each PR of course)