Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization #74

Open
SeadSilajdzic opened this issue Nov 5, 2021 · 4 comments
Open

Optimization #74

SeadSilajdzic opened this issue Nov 5, 2021 · 4 comments

Comments

@SeadSilajdzic
Copy link

Hello,
is there a way to optimize queries from this package?

Right now the query is "select * from table" and I guess that is not good because if someone is using this for bigger projects where there might be 10k users the application will use 50MB of ram and there will also be 10k models loaded and wait time will be about 3-5s.

We just need numbers of rows related to "created_at" or something like that we don't need all columns.

@PovilasKorop
Copy link
Collaborator

@SeadSilajdzic valid point, it's probably worth improving, but we don't actually know what fields we need, in some cases it's created_at, in other cases it's other fields, as there are a lot of grouping parameters.

So it's not an easy task to select the fields. But if you want to contribute, we would happily accept a Pull Request.

@SeadSilajdzic
Copy link
Author

Good point, but I guess 90% of people will work with dates. Will try to make it work for me and if I succeed I will contribute :)

@keatliang2005
Copy link

keatliang2005 commented Jul 11, 2023

What about have the ability to configure (based on time remembered) and cache generated result on dataset prepareData() method

@PovilasKorop
Copy link
Collaborator

@keatliang2005 same answer as above: if you want to contribute with your suggestion as a Pull Request, I'm happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants