Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: implementing jogCancel command for live jogging #73

Open
ibrahimuslu opened this issue Mar 1, 2019 · 2 comments
Open

FEATURE: implementing jogCancel command for live jogging #73

ibrahimuslu opened this issue Mar 1, 2019 · 2 comments

Comments

@ibrahimuslu
Copy link

ibrahimuslu commented Mar 1, 2019

Hello,

for the live jogging grblv1.1 implemented a jogcancel command with extended ascii commands
I have implemented it for arduino grblv1.1 but i dont know which commands for the other firmwares.

      appSocket.on('jogCancel', function () {
        writeLog(chalk.red('Jog Cancel'), 1);
        if (isConnected) {
            writeLog('Jog canceled and queue cleared', 1);
            switch (firmware) {
            case 'grbl':
                machineSend(String.fromCharCode(0x85))
                writeLog('Sent: Code(0x85)', 2);
                break;
            default:
                writeLog(chalk.red('ERROR: ') + chalk.blue('Unknown firmware!'), 1);
                break;
            }
        } else {
            io.sockets.emit("connectStatus", 'closed');
            io.sockets.emit('connectStatus', 'Connect');
            writeLog(chalk.red('ERROR: ') + chalk.blue('Machine connection not open!'), 1);
        }
    });
@ibrahimuslu ibrahimuslu changed the title implementing jogCancel command for live jogging FEATURE: implementing jogCancel command for live jogging Mar 1, 2019
@cprezzi
Copy link
Member

cprezzi commented Mar 1, 2019

I don't see the need for "jogCancel". Why not just use "resetMachine"? This can be quickly issued by pressing ctrl-x from the frontend.

@ibrahimuslu
Copy link
Author

ibrahimuslu commented Mar 1, 2019

Let me explain.
We are trying to use in lw.com.server and developing a new touch screen ui. jogcancel is stopping immediately the jog operation. there is no ctrl+x on touch screen.
on the live jogging we are trying to implement jogging while pressing the button and stop jogging when you stop pressing. There is no other option that i could find to stop jogging immedieately and enter to idle mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants