Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graded Assignment 2 - issues with starter code #78

Open
pjduri opened this issue May 28, 2024 · 1 comment
Open

Graded Assignment 2 - issues with starter code #78

pjduri opened this issue May 28, 2024 · 1 comment

Comments

@pjduri
Copy link

pjduri commented May 28, 2024

Instructions link:
https://education.launchcode.org/csharp-web-dev-curriculum/assignments/tech-jobs-oo/index.html

Starter code repo link:
https://github.com/LaunchCodeEducation/CSharp6-TechJobs-OO

Task 2 - Location test expecting wrong id - before Task 6 is complete it is expecting an Id of 2 but will always get 1, and afterwards it will always get 8.
Tasks 4 and 5 - missing using statement causes build errors when running tests. Suggest adding global using statement to Usings.cs in TechJobsOO.Tests project.
Task 5 - second and sixth tests failing due to missing file references, Ids in .txt files do not line up - Ids are different from machine to machine.

Link to doc created for March2024FTWD cohort with full explanation and fixes:
https://docs.google.com/document/d/1c_AjCYMi7cnmE0Ys74dLmadxe0DoayR9EZ08sdCbQ7w/edit?usp=sharing

@Carolista
Copy link

For at least some of the tests, one solution would be to have a getter for nextId so that you can look it up before more objects are created and generate the expected ids from there. I got different actual ids depending on whether I ran one test, some of the tests, or all of the tests (and also depending on how many tests existed at that point, as Patrick noted for Task 2 location test).

I realize this would not work as long as some of tests use the .txt files for expected values, so a different approach altogether might be needed there to make them deterministic and stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants