This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
flow (v2.x): differentiate target
and place
in navigation events
#381
Comments
changed description: clarified event parameters |
We also need to add target and place aware apis for the flow service. |
If both |
Marked breaking because place/target will now need to be differentiated both in navigateRequest events and constructAbsoluteUrl calls. |
x1B
changed the title
flow: (2.x) differentiate
flow: (v2.x) differentiate Nov 8, 2016
target
and place
in navigation events target
and place
in navigation events
Updated description to clarify where places/targets will be used in the future |
Updated, again |
x1B
changed the title
flow: (v2.x) differentiate
flow (v2.x): differentiate Nov 14, 2016
target
and place
in navigation events target
and place
in navigation events
x1B
added a commit
that referenced
this issue
Nov 25, 2016
x1B
added a commit
that referenced
this issue
Nov 25, 2016
x1B
added a commit
that referenced
this issue
Nov 25, 2016
x1B
added a commit
that referenced
this issue
Nov 25, 2016
Implemented on Breaking ChangeThe format of the flow definition has changed along with the configuration options:
For details, consult the updated flow manual. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As outlined in #373, there is currently no way to distinguish between flow-targets (relations from one place to another) and flow-places in navigation events. Both have valid use cases, and both can be used in
navigateRequest
events, although the event field is namedtarget
. However, it is not really obvious what happens if the current place uses a target that is also the name of a place. Further, place names may contain URL syntax, which is not actually allowed for use in event bus topics.When navigating directly by using links, the target is always set to
_self
, which is usually incorrect.Updated/Final/This-Time-For-Real Proposal for Target/Place Distinction
places
object of the flow definition), like targets, must be valid topics,target
innavigateRequest
events. If the current place has a matching target, that always takes precedence over a place of the same name,redirectParameters
.The previous proposals, for history completeness only:
New Proposal for Target/Place Distinction
Previous Proposal (just for informational purposes)
What we'd like:
"place"
instead of"target"
in navigateRequests, omitting the place name in the event topic for now,willNavigate
, use the resolved place (and the target if available),didNavigate
, use the same parameters as willNavigate.The text was updated successfully, but these errors were encountered: