Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

remove HTML5 router base from navigation events #383

Open
x1B opened this issue Oct 26, 2016 · 1 comment
Open

remove HTML5 router base from navigation events #383

x1B opened this issue Oct 26, 2016 · 1 comment
Labels
epic: runtime type: bug version: 1.x

Comments

@x1B
Copy link
Member

x1B commented Oct 26, 2016 •
edited
Loading

v1.x: Since adding support for pushState-style routes (html5Mode, since v1.3.0), navigation events reflect the router base-prefix, because that is dynamically added to the live flow definition. However, this leaks environment specific configuration through to the application layer, and may lead to bugs that only become apparent after deployment. So, the prefix always must be stripped from the generated URL.

For v2.x, we need to ensure that this is not an issue, or implement a fix as well (edit: issue does not exist in v2.x, see below).
@alex3683 alex3683 mentioned this issue Oct 26, 2016
Closed
5 tasks
@x1B x1B added this to the v2.0.0 milestone Nov 7, 2016
@x1B x1B self-assigned this Nov 8, 2016
@x1B
Copy link
Member Author

x1B commented Nov 8, 2016 •
edited
Loading

Update: because of the way that we use page.js and its base for routing, this is not an issue for LaxarJS v2.x. Removing Milestone.

@x1B x1B removed this from the v2.0.0 milestone Nov 8, 2016
@x1B x1B removed their assignment Nov 8, 2016
@x1B x1B changed the title flow: remove HTML5 router base from navigation events flow (v1.x): remove HTML5 router base from navigation events Nov 8, 2016
@x1B x1B changed the title flow (v1.x): remove HTML5 router base from navigation events remove HTML5 router base from navigation events Jan 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
epic: runtime type: bug version: 1.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@x1B