Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments explaining when our client is used instead of the rollup stack's client #184

Open
samlaf opened this issue Oct 12, 2024 · 1 comment
Assignees

Comments

@samlaf
Copy link
Collaborator

samlaf commented Oct 12, 2024

We have a client in the repo: https://github.com/Layr-Labs/eigenda-proxy/blob/feat--openapi-spec/client/client.go

Seems it's only used for simple commitments, meaning nitro doesn't have a client the same way op does?

Could we document this in the code, as comments above the client struct? And link to the op client, explaining why we only have a client for the simple commitment mode.

@samlaf
Copy link
Collaborator Author

samlaf commented Oct 13, 2024

Related to this, it seems like we use a query parameter of ?commitment_mode=simple to send simple commitments.
Could we change this to be in the path instead? like GET /get/simple/{hexEncodedCommitment}? Would greatly simplify the logic around here in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants