-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Local ESM import does not specify extension #7871
Comments
It looks like this may also be an issue in |
This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it. |
Still an issue in 6.29.4. |
This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it. |
6.29.4 is still the latest version. |
This issue is stale because it has been open 30 days with no activity. Remove stale label, comment, or consider closing it. |
Impacted Library name
@ledgerhq/hw-transport-web-ble
Impacted Library version
6.29.3
Describe the bug
lines 11 and 12 of TransportWebBLE.ts reference local imports. After building, the emitted .js file in
/lib-es/
does not specify the full path including extension and so attempting to reference the ESM version fails.Expected behavior
Importing from
@ledgerhq/hw-transport-web-ble/lib-es/TransportWebBLE.js
does not fail due to the aforementioned issue.Additional context
The reason I tried importing the file directly is because importing normally with
import { default as BluetoothTransport } from @ledgerhq/hw-transport-web-ble
does not properly import, and that is because it is being exported withexports.default = BluetoothTransport
instead ofmodule.exports = BluetoothTransport
in/lib/TransportWebBLE.js
.The text was updated successfully, but these errors were encountered: