Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest: should JSON output for devices be a dict or an array? #22

Open
lpascal-ledger opened this issue Mar 7, 2024 · 0 comments
Open
Labels
bug Something isn't working enhancement New feature or request question Further information is requested

Comments

@lpascal-ledger
Copy link
Contributor

lpascal-ledger commented Mar 7, 2024

Currently, when outputing the devices:

$ ledger-manifest ledger_app.toml  -od
devices:
0. stax
1. nanos+
2. nanos
3. nanox

$ ledger-manifest ledger_app.toml -j -od
{"devices": ["nanos+", "stax", "nanox", "nanos"]}

... which prevents to directly use ledger-manifest in shell scripts (including GitHub actions). One needs to:

compatible_devices="$(ledger-manifest --output-devices "$APP_MANIFEST" -j | jq -rc '.devices')";

What should be the proper behavior?

@lpascal-ledger lpascal-ledger added bug Something isn't working enhancement New feature or request question Further information is requested labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant