-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a "failsafe" flag for risky private operations #12
Comments
This is good, and maybe I can support withdraw feature with pyOTP, what do you think? |
That's a cool idea! Although I also respect your original choice of not implementing withdrawals. The main strength of this is for algorithmic trading, right? For that reason, I'm rethinking my suggestion to add failsafes. What do you think? |
Yes, I think failsafes is a good idea that users can decide how much they wanna risk. |
Can you give an example of how that API might work? |
which one? |
withdrawal with an OTP
|
but how would you integrate it with withdrawal methods?
|
Sorry for late, I will integrate this part after I finish final exam. |
For any private operations which are "risky" -- meaning that they'll actually do something with assets when they're called, like buy/sell assets -- what do you think about an
im_sure
flag which defaults toFalse
? And it could maybe raise an exception when it's set toFalse
saying "Please setim_sure
toTrue
if you want this transaction to go through."The text was updated successfully, but these errors were encountered: