Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a "failsafe" flag for risky private operations #12

Open
zevaverbach opened this issue May 11, 2021 · 9 comments
Open

Introduce a "failsafe" flag for risky private operations #12

zevaverbach opened this issue May 11, 2021 · 9 comments

Comments

@zevaverbach
Copy link
Contributor

For any private operations which are "risky" -- meaning that they'll actually do something with assets when they're called, like buy/sell assets -- what do you think about an im_sure flag which defaults to False? And it could maybe raise an exception when it's set to False saying "Please set im_sure to True if you want this transaction to go through."

@LeeChunHao2000
Copy link
Owner

This is good, and maybe I can support withdraw feature with pyOTP, what do you think?

@zevaverbach
Copy link
Contributor Author

That's a cool idea! Although I also respect your original choice of not implementing withdrawals. The main strength of this is for algorithmic trading, right?

For that reason, I'm rethinking my suggestion to add failsafes. What do you think?

@LeeChunHao2000
Copy link
Owner

Yes, I think failsafes is a good idea that users can decide how much they wanna risk.

@zevaverbach
Copy link
Contributor Author

Can you give an example of how that API might work?

@LeeChunHao2000
Copy link
Owner

which one?

@zevaverbach
Copy link
Contributor Author

zevaverbach commented May 14, 2021 via email

@LeeChunHao2000
Copy link
Owner

LeeChunHao2000 commented May 14, 2021

Params here, the last param code is 2fa code, we can get it via this lib.

totp = pyotp.TOTP('secret get from FTX 2fa setting')
totp.now() # => '492039'

@zevaverbach
Copy link
Contributor Author

zevaverbach commented May 14, 2021 via email

@LeeChunHao2000
Copy link
Owner

Sorry for late, I will integrate this part after I finish final exam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants