-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vertical/horizontal maximizing alters the other dimension #349
Labels
bug
Something isn't working
Comments
The (window) gaps are added to the window when it is maximized vertically/horizontally. It makes sense add the gaps if the window was already tiled. But I guess it is confusing, if the window is floating. |
Leleat
pushed a commit
that referenced
this issue
Jun 9, 2024
When maximizing a window vertically or horizontally, we've added gaps to the window. This makes sense if the window is already tiled. If the window is floating, we should add gaps to it even though we normally do to tiled windows. It should instead keep the same visible size. Fixes #349
Leleat
pushed a commit
that referenced
this issue
Jun 9, 2024
When maximizing a window vertically or horizontally, we've added gaps to the window like we normally do to tiled windows. This makes sense if the window is already tiled. If the window is floating, we shouldn't add gaps to it and instead should keep the currently visible size. Fixes #349
I've opened #353 to fix it. Feel free to try it out and see if it's works as you expect it to. |
Confirmed it works as expected now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When maximizing horizontally, the vertical size shrinks.
When maximizing vertically, the horizontal size shrinks.
Steps To Reproduce
Maximize vertically or horizontally with Gaps set to 10.
Demo:
2024-06-04-10.01.00.mp4
System Info:
main
branch...): 47 from extensions.gnome.org.Journalctl logs
No messages are logged.
Configuration
The text was updated successfully, but these errors were encountered: