Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical/horizontal maximizing alters the other dimension #349

Closed
F-i-f opened this issue Jun 4, 2024 · 3 comments · Fixed by #353
Closed

Vertical/horizontal maximizing alters the other dimension #349

F-i-f opened this issue Jun 4, 2024 · 3 comments · Fixed by #353
Labels
bug Something isn't working

Comments

@F-i-f
Copy link

F-i-f commented Jun 4, 2024

Describe the bug
When maximizing horizontally, the vertical size shrinks.
When maximizing vertically, the horizontal size shrinks.

Steps To Reproduce
Maximize vertically or horizontally with Gaps set to 10.
Demo:

2024-06-04-10.01.00.mp4

System Info:

  • Distro (incl. version): Fedora 40
  • GNOME Shell version: 46.2
  • Extension version and from where (e. g. EGO, main branch...): 47 from extensions.gnome.org.
  • XOrg/Wayland: Xorg

Journalctl logs
No messages are logged.

Configuration

$ dconf read /org/gnome/shell/enabled-extensions          
['tiling-assistant@leleat-on-github']
$ dconf dump /org/gnome/shell/extensions/tiling-assistant/
[/]
active-window-hint-color='rgb(53,132,228)'
enable-advanced-experimental-features=true
enable-tiling-popup=false
last-version-installed=47
maximize-with-gap=true
overridden-settings={'org.gnome.mutter.edge-tiling': <@mb nothing>}
restore-window=@as []
screen-bottom-gap=10
screen-left-gap=10
screen-right-gap=10
screen-top-gap=10
search-popup-layout=['<Super>semicolon']
show-layout-panel-indicator=false
tile-bottom-half=['<Super>period']
tile-bottomleft-quarter=['<Super>comma']
tile-bottomright-quarter=['<Super>slash']
tile-left-half=['<Super>l']
tile-maximize=['<Super>m']
tile-maximize-horizontally=['<Primary><Super>m']
tile-maximize-vertically=['<Shift><Super>m']
tile-right-half=['<Super>apostrophe']
tile-top-half=['<Super>bracketleft']
tile-topleft-quarter=['<Super>p']
tile-topright-quarter=['<Super>bracketright']
window-gap=10
@F-i-f F-i-f added the bug Something isn't working label Jun 4, 2024
@Leleat
Copy link
Owner

Leleat commented Jun 9, 2024

The (window) gaps are added to the window when it is maximized vertically/horizontally. It makes sense add the gaps if the window was already tiled. But I guess it is confusing, if the window is floating.

Leleat pushed a commit that referenced this issue Jun 9, 2024
When maximizing a window vertically or horizontally, we've added gaps to
the window. This makes sense if the window is already tiled. If the
window is floating, we should add gaps to it even though we normally do
to tiled windows. It should instead keep the same visible size.

Fixes #349
Leleat pushed a commit that referenced this issue Jun 9, 2024
When maximizing a window vertically or horizontally, we've added gaps to
the window like we normally do to tiled windows. This makes sense if the
window is already tiled. If the window is floating, we shouldn't add
gaps to it and instead should keep the currently visible size.

Fixes #349
@Leleat
Copy link
Owner

Leleat commented Jun 9, 2024

I've opened #353 to fix it. Feel free to try it out and see if it's works as you expect it to.

@F-i-f
Copy link
Author

F-i-f commented Jun 10, 2024

Confirmed it works as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants