Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Extension Rectification #26

Closed
Lewiscowles1986 opened this issue Nov 16, 2017 · 0 comments
Closed

Separate Extension Rectification #26

Lewiscowles1986 opened this issue Nov 16, 2017 · 0 comments
Assignees

Comments

@Lewiscowles1986
Copy link
Owner

https://github.com/Lewiscowles1986/WordPressSVGPlugin/blob/master/index.php#L83,L85

This is too detail oriented for a library with purpose to bring SVG support to WordPress. It also currently throws a warning in some PHP configurations as mentioned in #23.

Separate implementation to external dependency, possibly using composer autoloading.

This will also require a different release or upload format if using composer (bundled with frozen deps), and would benefit from #5 for all parts as well as #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant