Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated config options run_on_login and scriptlogin/script #50

Open
jfrsw opened this issue Feb 3, 2020 · 0 comments
Open

Duplicated config options run_on_login and scriptlogin/script #50

jfrsw opened this issue Feb 3, 2020 · 0 comments

Comments

@jfrsw
Copy link
Contributor

jfrsw commented Feb 3, 2020

While trying to implement a new stop_user_shell option for issue #39, I have found out that after commit e9727d2 there seems to be two settings for running scripts on user login: the old run_on_login on section [node] and the new script on section [scriptlogin]. Both options are also implemented on different places on the source code (run_on_login on LoginWindow::attemptLoginSuccess and scriptlogin/script on NetworkClient::doLoginTasks).

If those options are really duplicated, I think it would be good to chose either one (scriptlogin/script would be equivalent to run_on_login, and scriptlogout/scriptcould be implement as a new run_on_logout), and to decide which place works best for implementing this kind of option (LoginWindow::attemptLoginSuccess or NetworkClient::doLoginTasks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants