Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Django 4.0 support #9

Open
rlskoeser opened this issue Jul 26, 2022 · 4 comments
Open

Update for Django 4.0 support #9

rlskoeser opened this issue Jul 26, 2022 · 4 comments

Comments

@rlskoeser
Copy link

Are there any plans to update for django 4.0 ? If I opened a pull request with the needed changes, would someone be able to review and make a new release, or is this project no longer being maintained and I should look at switching to an alternate library?

@acdha
Copy link
Member

acdha commented Jul 27, 2022

If you submit a PR, I can review it

@rlskoeser
Copy link
Author

@acdha thanks, glad to hear that.

@rlskoeser
Copy link
Author

@acdha finally working on these updates (😅 trying to ignore the dates in this thread!) - I think I have the necessary fixes but wanted to check on approach before tidying up and making a pr.

Does it need to still work with older versions of django? Should the code try to import old/new versions of renamed packages, or ok to just target newer versions of django?

I have tox tests mostly passing with django 4.0 and 4.1 - I'm not sure if the ones that are failing ever worked / should work

@acdha
Copy link
Member

acdha commented Aug 13, 2024

Does it need to still work with older versions of django? Should the code try to import old/new versions of renamed packages, or ok to just target newer versions of django?

My thought is that we can track Django's mainstream support versions – people can pin the version if they can't upgrade because it seems highly unlikely that they won't need to pin older versions of many other dependencies as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants