Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Metal (macOS) #1

Open
pierotofy opened this issue Sep 23, 2023 · 2 comments
Open

Add support for Metal (macOS) #1

pierotofy opened this issue Sep 23, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@pierotofy
Copy link
Member

pierotofy commented Sep 23, 2023 •
edited
Loading

On macOS, OpenNMT-Py does not have support for metal devices (mps), but pytorch does.

It's possible to manually patch OpenNMT-Py and change torch.device('cpu') references to torch.device('mps') and get metal support to work, perhaps we could send a patch upstream to enable Metal support for everyone.

Seems kind of slow though.
@pierotofy pierotofy added the enhancement New feature or request label Sep 23, 2023
pierotofy pushed a commit that referenced this issue May 22, 2024
@lecoqnicolas
Merge pull request #1 from lecoqnicolas/lecoqnicolas-comet-evaluation
0b9bebc 
Add COMET evaluation
@PakanAngel
Copy link

Still cannot get it done on M3 with MPS. M3 CPU takes too long.
Any help to get it done on M3 MPS.

@unizhu
Copy link

unizhu commented Oct 25, 2024

+1 , please support for MPS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@unizhu @pierotofy @PakanAngel