You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prior to utilization of TinyCIFAR10DataModule I did a check on its (under review) code. Ι realized that there is a bug/typo inside __init__, where self.extra_args variable is set:
This is in contrast to self.EXTRA_ARGS which is already defined and used by the methods of the base class as required to pass the correct extra arguments to the underlying dataset:
A similar case that self.extra_args is used is inside CityscapesDataModule, however there the implementation is self-contained and does not depend on base class for train_dataloader and test_dataloader.
Besides the bug, is there a motivation about why a capitalized version of the variable was preferred inside VisionDataModule?
The text was updated successfully, but these errors were encountered:
Borda
changed the title
Wrong case of class variable inside TinyCIFAR10DataModule
Wrong case of class variable inside TinyCIFAR10DataModuleJun 20, 2023
🐛 Bug
Prior to utilization of TinyCIFAR10DataModule I did a check on its (under review) code. Ι realized that there is a bug/typo inside
__init__
, whereself.extra_args
variable is set:lightning-bolts/pl_bolts/datamodules/cifar10_datamodule.py
Line 182 in 2fdb818
This is in contrast to
self.EXTRA_ARGS
which is already defined and used by the methods of the base class as required to pass the correct extra arguments to the underlying dataset:lightning-bolts/pl_bolts/datamodules/vision_datamodule.py
Lines 105 to 106 in 2fdb818
A similar case that
self.extra_args
is used is inside CityscapesDataModule, however there the implementation is self-contained and does not depend on base class fortrain_dataloader
andtest_dataloader
.Besides the bug, is there a motivation about why a capitalized version of the variable was preferred inside VisionDataModule?
The text was updated successfully, but these errors were encountered: