New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

required parameters must come before optional ones #73

Open

tacman opened this issue May 23, 2024 · 1 comment

Collaborator

tacman commented May 23, 2024

In this function, the guesser is optional but the resolver is required.

I think we should reverse the order of the parameters.

 public function __construct(TranslatorInterface $translator, 
    FormTypeGuesserInterface $validatorGuesser = null, 
    ResolverInterface $resolver)

tacman added a commit to survos/Liform that referenced this issue


          use rector for 8.2 rules, fixes Limenius#73

6f06257

Member

nacmartin commented May 27, 2024

Yes, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment