-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't connect to host behind NAT after change by not reporting ExternalIP #1453
Comments
Manually reverting/patching src/nvhttp.cpp fixes issue. So it is a root cause |
Please provide the commit for reference. |
This is the commit 25e0244 |
Please provide specifics about which addresses are used by each hop between client and server and what address was being advertised by Sunshine prior to the change. How do your clients discover your host initially? Remember that this serverinfo page is only accessible if you already know the server's IP address. If your clients can reach the server to get the updated ExternalIP value, then they don't need it because they can already talk to the server. Moonlight will perform STUN requests on behalf of the host when you're on the same RFC1918 subnet to identify the WAN address and remember it for future use. Moonlight also remembers the address you use when adding the PC. If you're port forwarding through the VPS to you just specify the WAN address of the VPS and Moonlight remembers it |
I add a client when a client is in the same subnet as host. Previously it used ExternalIP value (when it was exposed) from the host to remember the internet public IP. The communication when the client is not in the same subnet is: I think in my setup there is no other way to get WAN IP other than the exposed ExternalIP field because VPS server is not the default gateway for the my host in local network. Each local network connected site-to-site has got its own seperate local default internet gateway |
Could you apply this patch please? It solves the issue --- Sunshine/src/nvhttp.cpp 2023-07-04 18:08:31.176849000 +0200
+++ nvhttp.cpp 2023-07-18 18:07:09.587892000 +0200
@@ -632,6 +632,10 @@
tree.put("root.ServerCodecModeSupport", "3");
}
+ if (!config::nvhttp.external_ip.empty()) {
+ tree.put("root.ExternalIP", config::nvhttp.external_ip);
+ }
+
pt::ptree display_nodes;
for (auto &resolution : config::nvhttp.resolutions) {
auto pred = [](auto ch) { return ch == ' ' || ch == '\t' || ch == 'x'; }; |
It seems this issue hasn't had any activity in the past 90 days. If it's still something you'd like addressed, please let us know by leaving a comment. Otherwise, to help keep our backlog tidy, we'll be closing this issue in 10 days. Thanks! |
This issue was closed because it has been stalled for 10 days with no activity. |
Hello, I still apply this patch when I build sunshine. I can't access the machine without it when I connect through the internet. |
Is there an existing issue for this?
Is your issue described in the documentation?
Is your issue present in the nightly release?
Describe the Bug
Can't connect to host behind NAT after change by not reporting ExternalIP.
I have a host behind NAT and my clients can't find the host through the internet.
My setup: client->internet->vps server->vpn network->local network-> host
Please revert this change 25e0244
Expected Behavior
Client can find external internet ip and connect to it
Additional Context
No response
Host Operating System
Linux
Operating System Version
Arch Linux with all updates
Architecture
64 bit
Sunshine commit or version
nightly and master
Package
Linux - AUR (Third Party)
GPU Type
AMD
GPU Model
AMD Radeon RX 580
GPU Driver/Mesa Version
Latest mesa git from arch repo http://pkgbuild.com/~lcarlier/$repo/$arch
Capture Method (Linux Only)
Wayland
Config
Apps
No response
Relevant log output
The text was updated successfully, but these errors were encountered: