Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search Bug #4 #6

Open
LolfoollorS opened this issue Oct 28, 2022 · 1 comment
Open

Search Bug #4 #6

LolfoollorS opened this issue Oct 28, 2022 · 1 comment

Comments

@LolfoollorS
Copy link
Owner

LolfoollorS commented Oct 28, 2022

Related to #1
Search or function is not working as intended.

input: search t/z or t/colleague

expected: either invalid colleague tag (0 search result) or Alice Wonderland (1 search result (has t/z))


video:https://raw.githubusercontent.com/LolfoollorS/ped/main/files/f5f9cf0a-62a0-42e2-b364-c66ff13e0744.mp4

@florentianayuwono
Copy link

Hi there! It's me again😉

From our UG:
image

Same as before, you can try search or t/z t/colleagues to return all contacts with tag z or colleagues.

If you only type search or t/z t/colleague, then it will return contacts with tag z only, IF there is no contacts with tag colleague.

However, if you type search t/z or t/colleague, then since none of the contacts contains tag z or or colleague, it will resort to give you relevant search instead. Since we want our relevant search to still be precise, we would only return the contact if majority of the information there match you original search query. As you can see, it will still return contacts with colleagues, since our algorithm know that most likely you mistype colleagues to be colleague. However, our algorithm cannot guarantee that you really want contacts with tag z only instead of z or. Notice that your search query only match like 25% of the original contact information. That's why our algorithm chooses to exclude contacts with tag z only.

We encourage you to try again and do let us know if you still face the same issue. In the actual pe, don't forget to also read the UG command format correctly😀. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants