PSReviewUnusedParameter in-place suppression instead of disabling the rule (OSOE-528)

[BenedekFarkas]

The PSReviewUnusedParameter is disabled in our current configuration, because it produces false positives when a parameter is only used in a local function, but not in the main script body. See PowerShell/PSScriptAnalyzer#1472.

A recent comment (PowerShell/PSScriptAnalyzer#1472 (comment)) tipped me off to try suppressing those cases in-place, so we can re-enable the rule.

Jira issue

[Piedone]

Shouldn't we instead wait for the bug to be fixed? In your PRs I see only suppressions, but no change due to the rule finding an issue. So, while it may catch issues in the future, apparently we don't have those frequently, and now it only necessitates suppressing false alarms.

[BenedekFarkas]

The issue has been open for 2 and a half years, so why should we wait more?
There were a handful of true positives I fixed during one of the previous issues.

[Piedone]

This rule currently brings more suppressions than fixes. So I don't see why we'd use it, especially since the bugs it guards against are minor.

[Piedone]

@DAud-IcI please see this discussion.

[sarahelsaig]

Ah, I reviewed this a few hours earlier but then took a nap because the merging seemed complex. Shouldn't have slacked if I knew it leaves time for discussion. 😁
Anyway, it's pretty inconsequential either way, since only 2 scripts had to be suppressed.

[Piedone]