Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run pytests on open PR #1167

Closed
CBroz1 opened this issue Oct 15, 2024 · 2 comments
Closed

Run pytests on open PR #1167

CBroz1 opened this issue Oct 15, 2024 · 2 comments

Comments

@CBroz1
Copy link
Member

CBroz1 commented Oct 15, 2024

Currently test-conda.yml runs on a schedule. Ideally, these would run when opening a PR to catch issues before they're merged.

Currently, our data is hosted on Box, which requires a user password to saved as a secret. To run tests on PR would require some additional measures to avoid a security vulnerability - essentially gating this run on admin approval.

We can either ...

  • Change how the data is fetched...
    • Changing service provider to something that does not require credentials
    • Perusing a different account option through Box, not requiring user password
    • Preserve data on GitHub between runs
  • Add gate-keeping measures for these tests (e.g., admin must approve or label PR before tests run), making for a more cumbersome approval process
@CBroz1
Copy link
Member Author

CBroz1 commented Oct 15, 2024

Or just change around the wget to pull each file individually, like this

@CBroz1 CBroz1 mentioned this issue Oct 15, 2024
7 tasks
@CBroz1
Copy link
Member Author

CBroz1 commented Nov 20, 2024

Fixed by #1180

@CBroz1 CBroz1 closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant