-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
console: move ui to libtrx #1541
Conversation
082c783
to
7abc1fc
Compare
The prior issues are now resolved, thank you. I've noticed a small issue - the blinking caret is slower now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blinking caret LGTM. 👍
Fixed, but I can't say I like my solution. @lahm86 could you please take a look around the code, especially libtrx, and LMK if you see anything that I could've done better? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at all text scalings
I've improved the APIs a bit and I'm a bit happier. There are still some design smells such as UI having to be initialized after the config or else reacting to text scaling changes will not work, or the config |
Checklist
Description
LostArtefacts/libtrx#37