From 2158fd6c951959f7f18b8e6eb81b4c677da90b17 Mon Sep 17 00:00:00 2001 From: Abdelrahman Ashraf Date: Tue, 10 Dec 2024 14:33:16 +0700 Subject: [PATCH] refactor: Update clippy command in Makefile and build workflow Update the clippy command in the Makefile to use the --no-default-features flag and add the thorvg-v1 feature. Also, update the build workflow to remove the --all-features flag when running cargo clippy for dotlottie-rs and dotlottie-ffi. --- .github/workflows/check-pr.yaml | 4 ++-- Makefile | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/check-pr.yaml b/.github/workflows/check-pr.yaml index 03177e98..134fc8b3 100644 --- a/.github/workflows/check-pr.yaml +++ b/.github/workflows/check-pr.yaml @@ -40,7 +40,7 @@ jobs: - name: Lint run: | - cargo clippy --manifest-path=./dotlottie-rs/Cargo.toml --all-targets --all-features -- -D clippy::print_stdout - cargo clippy --manifest-path=./dotlottie-ffi/Cargo.toml --all-targets --all-features -- -D clippy::print_stdout + cargo clippy --manifest-path=./dotlottie-rs/Cargo.toml --all-targets -- -D clippy::print_stdout + cargo clippy --manifest-path=./dotlottie-ffi/Cargo.toml --all-targets -- -D clippy::print_stdout env: RUSTFLAGS: "-Dwarnings" diff --git a/Makefile b/Makefile index 9ad975ef..b9789796 100644 --- a/Makefile +++ b/Makefile @@ -405,7 +405,8 @@ define UNIFFI_BINDINGS_BUILD rm -rf $(RUNTIME_FFI)/$(RUNTIME_FFI_UNIFFI_BINDINGS)/$(BINDINGS_LANGUAGE) cargo run \ --manifest-path $(RUNTIME_FFI)/Cargo.toml \ - --features=uniffi/cli \ + --no-default-features \ + --features=uniffi/cli,thorvg-v1 \ --bin uniffi-bindgen \ generate $(RUNTIME_FFI)/src/dotlottie_player.udl \ --language $(BINDINGS_LANGUAGE) \