refactor(svelte): migrate to svelte 5 #391
Conversation
|
moonlitgrace
changed the title
| @@ -98,14 +98,13 @@ | |||
| }); | |||
|
|
|||
| $effect(() => { | |||
| console.log(speed); | |||
| if (dotLottie && dotLottie.isLoaded && typeof speed == 'number') { | |||
| if (dotLottie && typeof speed == 'number' && dotLottie.isLoaded) { | |||
There was a problem hiding this comment.
changed order of conditions, cause isLoaded is not reactive which blocking svelte from getting to next reactive object which is speed.
thanks to sveltejs/svelte#14517 (comment)
There was a problem hiding this comment.
hey @theashraf, can i get a review on this?
There was a problem hiding this comment.
@moonlitgrace Sorry for the late reply. Is the PR ready for review?
Before that, I'm not sure if Svelte 5 is backward compatible with Svelte 4. Is that the case? If it is, we’ll also need to update the peer dependencies of the dotlottie-svelte package to include both v4 and v5 of Svelte.
There was a problem hiding this comment.
hi @theashraf, wishing you a very happy new year (a bit late ik) and sry for the delay.
yes, PR is ready for review. if i remember correctly, i actually requested this change, let me know if you have any constraints regarding the ordering.
I'm not sure if Svelte 5 is backward compatible with Svelte 4. Is that the case?
it should be, but i didnt test it. something seemed off last time i tried running a Svelte 4 project, everything changed/updated to Svelte 5. well, i will give it another shot and update you.
|
related -> #438 |
Description
🚧 WIP: Migrating to Svelte 5, it is stable now.
Type of change
Checklist