Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: the appInstance variable is shared by all the instances of the web component #46

Open
humanchimp opened this issue Jul 13, 2023 · 0 comments

Comments

@humanchimp
Copy link

Hello. The appInstance variable is shared by all the instances of the web component in a manner that is subject to race conditions. i recommend storing it as an instance property on the class instead. This bug exhibits when multiple instances will contend for that variable, and then they'll end up dispatching, say webComponentAttributeChanged, to the wrong instance. I hope someone finds this insight helpful! Sorry I didn't have time to make a PR. Thanks!

@humanchimp humanchimp changed the title bug: the appInstance variable is shared over all the instances of the web component bug: the appInstance variable is shared by all the instances of the web component Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant