Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ddev post-start hook to remove Dockerfile.playwright #11

Open
deviantintegral opened this issue Aug 5, 2024 · 1 comment
Open

Comments

@deviantintegral
Copy link
Member

Once the containers are started, we don't need this file anymore. If we remove it, then we know that users won't accidentally commit it to git in case they miss that setup step.

@penyaskito
Copy link
Member

tbh I'd prefer we add a gitignore file? Problem is that another add-on might be doing that too, and they would collide.

Maybe adding a .gitignore.ddev-playwright and calling in post-install

git config core.excludesfile .gitignore.ddev-playwright

is a better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants