Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Investigate downloading PDF.js at runtime. #26

Open
Lunarequest opened this issue May 17, 2023 · 0 comments
Open

Investigate downloading PDF.js at runtime. #26

Lunarequest opened this issue May 17, 2023 · 0 comments
Assignees
Labels
feature feature reqeust triage/investigation look into the impact of this issue

Comments

@Lunarequest
Copy link
Owner

Currently we use an inline version of PDF.js that is stored in app/libs/pdfjs by moving pdfjs outside the application instead shipping our own pdfjs version.

-- drawbacks
network access will always be required on first start up
on slow networks this could greatly increase download times.
this could also increase startup times on launch

-- possible mitigations
ship a cached pdfjs.zip(latest at time of build) and extract allowing the user to use nightpdf immediately.
produce a notification on a newer PDF.js and download only if the user requests
only check for new releases after launch asynchronously.

-- benfits
user always has the latest PDF.js version which often can include fixes and improvements
we can remove PDF.js from our direct source tree and move it elsewhere

@Lunarequest Lunarequest added triage/investigation look into the impact of this issue feature feature reqeust labels May 17, 2023
@Lunarequest Lunarequest self-assigned this May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature feature reqeust triage/investigation look into the impact of this issue
Projects
None yet
Development

No branches or pull requests

1 participant