Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎯 Welcome: Spoiler / Issues / Contribution / Discussions / Feedback #104

Closed
Lurkars opened this issue Feb 2, 2023 · 4 comments
Closed
Labels
documentation Improvements or additions to documentation

Comments

@Lurkars
Copy link
Owner

Lurkars commented Feb 2, 2023

Welcome

Here are some short infos/guidelines about this repository. My timezone is GMT+1, so just as info when I am giving ETAs like today.

Spoiler

Please take a look at Spoiler Warnings!

Issues

You should create an issue if you

  • experience any bug/technical issues ("I cannot add curses to AM deck!")
  • have a concrete feature request ("Please add keyboard shortcut for drawing AM")

If you just have ideas or want to discuss behavior, please create a Discussion.

Every issue should contain a detailed description of the problem/improvement. Depending on the problem, please provide the following information

  • GHS Version (you found the number in Menu under About)
  • Browser/OS
  • if server is used: self-hosted or public
  • if you referring to a scenario/section always provide edition (short version is enough)

Issue workflow

I am using a simple issue workflow by using the label function

  • mostly two categories, to categorize the issue
    • bug Something isn't working as expected for issues
    • enhancement New feature or request for improvements/new features
  • issue states
    • in progress Currently working on this currently working on this
    • to test Should be fixed, but needs proper testing this should be fixed/done, but needs to be verified
    • backlog This will not be worked on yet, but will come in future will be worked on in the future, but not yet
    • pending Additional information/feedback requested if more information or feedback is required to determine the issue (so mostly issue is assigned back to creator)
    • wontfix This will not be worked on this will not be worked on (mostly then closed afterwards)

In most cases, I would mark a new issue as backlog This will not be worked on yet, but will come in future or in progress Currently working on this (when directly start working on it) and assign it to me. After the issue is solved, it will remain open and going in to test Should be fixed, but needs proper testing assigning the issue back to the report to verify the fix.

Contribution

I am really happy about any contribution. Please just use a brief description about what your PR does. It's easier to validate your PR if the description already saying "fixes standee data in GH scenario # 5" than me looking at the files and trying to determine this information.

Discussions

The GitHub Discussion section is for everything that involves a bit more conversation:

  • 🙏 Q&A: If you just need help or other questions
  • 💡 Ideas If you have an idea, but need more input or want to give/get feedback
  • 🗳️ Polls: This will mostly come out from an Idea discussion, if some ideas may conflict, we can start a poll. Other use cases would be to get community feedback about what to prioritize

Use the label feedback Just a personal feedback , help wanted Extra attention is needed or question Specific question to be answered for marking your discussion category.

@Lurkars Lurkars pinned this issue Feb 2, 2023
@Lurkars Lurkars closed this as completed Feb 2, 2023
@Lurkars Lurkars added the documentation Improvements or additions to documentation label Feb 2, 2023
@itemforty

This comment has been minimized.

@Lurkars

This comment has been minimized.

@ruanmed
Copy link

ruanmed commented Jun 30, 2024

Hi @Lurkars , I could work in a translation for Portuguese (Brazilian) - pt-BR for the application, based on the official translated version of Gloomhaven published in Brazil by Galápagos Jogos that I own.

Since there are already three different language localizations here (de, fr and kr), would you know if I need to get any permission from Galápagos Jogos in Brazil to use the same terms they used in their translations?
My concern is if I'd be breaking any copyright they have for the translations (if that's even possible), or if using their translations here would fall under fair use regardless.

@Lurkars
Copy link
Owner Author

Lurkars commented Jun 30, 2024

Hi @Lurkars , I could work in a translation for Portuguese (Brazilian) ....

Moved this to a new discussion, since this not the place to discuss. #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants