Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A player cannot have two characters #494

Open
jorge-graca-sky opened this issue Jan 23, 2024 · 7 comments
Open

A player cannot have two characters #494

jorge-graca-sky opened this issue Jan 23, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request to test Should be fixed, but needs proper testing

Comments

@jorge-graca-sky
Copy link
Contributor

jorge-graca-sky commented Jan 23, 2024

Describe the bug

If a player "sets aside" a caracter and creates another, the old caracter has it's player changed in the character sheet.

Game Enviroment

Between scenarios

To Reproduce

Create a new character and assign it a player that already has a character

Expected behavior

A player can have has many characters as possible, but only one active per adventure.

Gloomhaven Secretariat Version

0.84.11

Used Browser

Chrome

OS

iOS 14.2.1

Additional

No response

@jorge-graca-sky jorge-graca-sky added the bug Something isn't working as expected label Jan 23, 2024
@Lurkars
Copy link
Owner

Lurkars commented Jan 24, 2024

Thanks. I will think about this. In the meantime I can provide a hacky workaround for this: there is an Import/Export function on the character sheet. So to switch characters, you can export one, remove character, add new character for player. Afterwards, export new one, remove and add previous one and then import file.

@jorge-graca-sky jorge-graca-sky changed the title A player cannot have two caracters A player cannot have two characters Jan 26, 2024
@Lurkars Lurkars added enhancement New feature or request and removed bug Something isn't working as expected labels Feb 19, 2024
Lurkars added a commit that referenced this issue Feb 19, 2024
@Lurkars
Copy link
Owner

Lurkars commented Feb 19, 2024

So in v0.89.0 I now added this small feature.
When not in a scenario, you have a small new action on the character sheet to deactivate a character:
deactivate

You can now add a new character for that player. If you want to re-activate, you need to go to the global campaign sheet and next to the player name input, all available characters are listed with their icons. A normal click just opens the character sheet, to re-activate double click (long press on mobile) on the icon. If the player has any active character it will be deactivated then.
reactivate

Also remember that any deactivated character is not available to add as new character (as per rules!).

@Lurkars Lurkars assigned jorge-graca-sky and unassigned Lurkars Feb 19, 2024
@Lurkars Lurkars added the to test Should be fixed, but needs proper testing label Feb 19, 2024
@Lurkars
Copy link
Owner

Lurkars commented Feb 19, 2024

Happy about feedback and if this solves your issue, please close it. Thanks.

@jorge-graca-sky
Copy link
Contributor Author

Will test as soon as I can, but probably not soon sadly :(

An initial feedback is why not use the actual rules words? They say "set aside" so why not "set aside character"?

@Lurkars
Copy link
Owner

Lurkars commented Feb 19, 2024

Just didn't knew official wording. Will update.

@jorge-graca-sky
Copy link
Contributor Author

Just didn't knew official wording. Will update.

This github is very useful:
https://pikdonker.github.io/frosthaven-rule-book/#page_65

:D

Lurkars added a commit that referenced this issue Feb 20, 2024
…huffle upcoming cards only to all card menus, small other fixes and improvements
@Lurkars
Copy link
Owner

Lurkars commented Feb 20, 2024

Changed naming in v0.89.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request to test Should be fixed, but needs proper testing
Projects
None yet
Development

No branches or pull requests

2 participants