Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escort initiative gets re-ordered by remote client #563

Open
fonikz opened this issue May 7, 2024 · 2 comments
Open

Escort initiative gets re-ordered by remote client #563

fonikz opened this issue May 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working as expected to test Should be fixed, but needs proper testing

Comments

@fonikz
Copy link

fonikz commented May 7, 2024

Describe the bug

Whenever a remote client performs an action, Escort with initiative 99 will be automatically pushed to the very front of the initiative stack.

Game Enviroment

Running ghs-server-v0.95.0.

I connect on same machine via Chromium browser with all permissions. Client 0.95.15.

Another player is connected via iPad running Safari, on local WiFi. Client 0.95.15. Permissions are
{"characters":true,"character":[],"monsters":true,"monster":[],"scenario":false,"elements":true,"round":true,"level":false,"attackModifiers":false,"lootDeck":false,"party":true}

Running campaigns 19 and 27, escort is set up automatically.

To Reproduce

  1. Go to iPad client, connect in Safari
  2. Perform any action, i.e. add initiatives, modifying elements.
  3. See error: escort is thrust to the very top of the initiative stack (as if initiative 0, but visually still says 99) and will activate next when you tab through the current active character/monsters.

Expected behavior

Escort with initiative 99 should remain at the end of the initiative stack no matter

Gloomhaven Secretariat Version

v0.95.15

Used Browser

Safari (unsure version, latest assumed)

OS

iPadOS 17

Additional

No response

@fonikz fonikz added the bug Something isn't working as expected label May 7, 2024
Lurkars added a commit that referenced this issue May 8, 2024
@Lurkars
Copy link
Owner

Lurkars commented May 8, 2024

Thanks, I was already able to reproduce just by refreshing site. It was not related to server in any way, but the way the game state was stored (especially objectives...). Should be fixed now in v0.96.0. So happy if you can test again and close issue if solved.

@Lurkars Lurkars added the to test Should be fixed, but needs proper testing label May 8, 2024
@Lurkars Lurkars assigned fonikz and unassigned Lurkars May 8, 2024
@Jaerin
Copy link
Contributor

Jaerin commented May 16, 2024

This worked in our last scenario. The special we had no longer had its initiative updated from the starting value like it used too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected to test Should be fixed, but needs proper testing
Projects
None yet
Development

No branches or pull requests

3 participants