Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force inlining of svgs #157

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

jkrumbiegel
Copy link
Contributor

In Makie I noticed that the inlined images don't always look right and it would be simpler to just use separate files. So I've added this branch where the condition is checked which seems to be the reason that the previous workaround existed. Although I can't get a valid svg display anyway in Firefox if I remove the xmlns from a test string.

@jkrumbiegel jkrumbiegel changed the title Don't force inlining Don't force inlining of svgs Jun 21, 2024
@jkrumbiegel jkrumbiegel marked this pull request as ready for review June 24, 2024 09:01
@lazarusA
Copy link
Collaborator

lazarusA commented Jun 24, 2024

if we want this to be supported by default, we should add the setting also to the template.

Here: https://github.com/LuxDL/DocumenterVitepress.jl/blob/master/template/src/.vitepress/config.mts

Edit: Or mention the setting here, so that people know what to do: https://luxdl.github.io/DocumenterVitepress.jl/dev/mime_examples

Don't force inlining of svgs

::: info config.mts

 vite: {
    build: {
      assetsInlineLimit: 0, // so we can tell whether we have created inlined images or not, we don't let vite inline them
    }
  },

:::

@lazarusA lazarusA merged commit 9243328 into LuxDL:master Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants