Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Tutorial for LiveServer usage #165

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Conversation

TheCedarPrince
Copy link
Contributor

This introduces a tutorial to complement #164 based on a long work session with @asinghvi17 .

@asinghvi17 , for deployments, will the creator need to remove these tweaks from their make.jl file? Or can these tweaks be safely left in when deployed? I wasn't sure if they could be left in or not.

Otherwise, feel free to make additional tweaks here as needed!

@asinghvi17
Copy link
Collaborator

For deployment you would need to remove all tweaks, maybe we can make a convenience function to do this for you though (something like MarkdownVitepress(...) |> live_serveable maybe.

@TheCedarPrince
Copy link
Contributor Author

That sounds great @asinghvi17 -- do we want to make that functionality now and then merge these two PRs or go ahead and merge the tutorial + your functionality that you just added and make this live_serveable function later? 🤔

docs/src/getting_started.md Outdated Show resolved Hide resolved
docs/src/getting_started.md Show resolved Hide resolved
@TheCedarPrince
Copy link
Contributor Author

Added this in @asinghvi17 !

Copy link
Collaborator

@asinghvi17 asinghvi17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TheCedarPrince!

@asinghvi17 asinghvi17 merged commit ef3bc2d into LuxDL:master Jun 30, 2024
@TheCedarPrince
Copy link
Contributor Author

Right back at ya @asinghvi17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants