-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement AES encryption on strings passed into the cipher. #3
Comments
I think the |
p.s Glad to see you around again @TotallyNotChase always appreciate your PRs ;) |
So, a little progress update, I was reading into AES encryption and according to its standards, we'll need an also sorry for the massive delay, a bit busy this week but I highly advise leaving the library unchanged. Expect a PR by 12th dec :) |
All good! I will not be touching it until you make your PR as you always seem to have great refactoring changes to go along with your logical changes. As for the initialization vector I think we can generate one using this: |
I've assigned this ticket to you @TotallyNotChase, it seems you are going to be taking this on and I'm excited to see the PR you come up with. Always appreciated. |
This gist looks like a good reference point for generating AES encrypted strings and decrypting: https://gist.github.com/mborgerson/9847638 EDIT: Disclaimer!! Be careful for vulnerabilities in stream cipher attacks if using this method of AES or any AES Stream Ciphers for that matter. I'll review during code review of your PR but i would still check to make sure while self-reviewing! |
In order to make this more cryptographically secure we should implement some sort of AES standard into the strings that are encrypted and add that to the encryption and decryption functions respectively.
The text was updated successfully, but these errors were encountered: