Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the state of Mock Blockchain Client Server #805

Open
Syther007 opened this issue Jul 29, 2024 · 1 comment
Open

Review the state of Mock Blockchain Client Server #805

Syther007 opened this issue Jul 29, 2024 · 1 comment

Comments

@Syther007
Copy link
Collaborator

Syther007 commented Jul 29, 2024

MockBlockchainClientServer has been migrated to masq_lib/src/test_utils/mock_blockchain_client_server.rs
From multinode_integration_tests/src/mock_blockchain_client_server.rs

So we have access for testing in Node.

However the currents tests for MockBlockchainClientServer rely on Docker and unable to be migrated at the same time.

This card is to remind us to come up with a solution to resolve this.
We currently need MockBlockchainClientServer in node and in multinode_integration_tests.

Maybe it would be more appropriate to re-write these test's with out Docker?

@kauri-hero
Copy link

there is not a lot of knowledge on the ganache servers and tests written - there are a few.
will need to consider how to address this knowledge gap

ganache has been replaced by hardhat amongst the industry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🔖 Ready
Development

No branches or pull requests

2 participants