Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

´RationalFunctionField` causes problems #134

Closed
swewers opened this issue Sep 5, 2024 · 2 comments
Closed

´RationalFunctionField` causes problems #134

swewers opened this issue Sep 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@swewers
Copy link
Contributor

swewers commented Sep 5, 2024

In Sage 10.4,

sage: F0. = FunctionField(QQ)
sage: R. = F0[]
sage: F. = F0.extension(y^2-x^3-x)
sage: Y = SmoothProjectiveCurve(F)

gives the error message

ImportError: cannot import name 'RationalFunctionField' from 'sage.rings.function_field.function_field' (/home/stefan/code/sage/sage/src/sage/rings/function_field/function_field.py)

The problem is the line

assert isinstance(F, RationalFunctionField)

in "smooth_projective_curves.py".

As a preliminary fix, I would just remove this line. But what would the good solution be here?
@swewers swewers added the bug Something isn't working label Sep 5, 2024
swewers added a commit that referenced this issue Sep 5, 2024
@swewers
Preliminary fix of issue #134
742e552 
The two line where `RationalFunctionField` appear
are commented out. This is a temporary fix of the
issue.
swewers added a commit that referenced this issue Sep 9, 2024
@swewers
Merge pull request #135 from MCLF/fix_rational_function_field
ff05ae7 
Preliminary fix of issue #134
@fchapoton
Copy link
Contributor

from sage.rings.function_field.function_field_rational import RationalFunctionField

@swewers
Copy link
Contributor Author

swewers commented Oct 31, 2024

This is now fixed.

@swewers swewers closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fchapoton @swewers