-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Residue fields should be of natural type and functorial #66
Comments
Could you create an upstream trac ticket for this? |
Ok, I will do it soon, but first I want to think more about it and in which situations it is relevant. |
Actually, I think both 1. and 2. should be checked by an automated test. Then we see immediately where this currently fails. There might be some cases where we don't think it's worth to fix it of course. |
I created https://trac.sagemath.org/ticket/25976 so I can push my test code somewhere. Please improve on the once we have figured out what we want exactly :) |
Functoriality is actually complicated: I don't want valuations to remember how they were constructed. This would create a lot of trouble (as a bad example, last time I checked, number fields remember a certain complex embedding, and this has bitten me several times already that seemingly identical objects are somehow distinct.) Requiring If we absolutely need this information, then we'd need a variant of Anyway, let's see how my tests go first… |
I understand. In many places, having the correct embedding of residue fields of extensions is crucial. An option like |
In connection to issue #103 I now realize that the type of the residue field of a valuation is maybe not so crucial. Crucial is the possibility to define an isomorphism between the residue field and a field of the 'natural type', and more generally embeddings of the residue field into quite arbitrary fields. The typical example is that I have a curve X over a p-adic field K and a non-standard valuation v on the function field of X (extending the base valuation on K, residue field of dimension one). I think of v as a Type-II-point xi on the Berkovich space X^an. I want to have the option of realizing the residue field of v as a function field over the residue field of K, but also as a function field over any intermediate field between the residue field of K and the field of constants of this function field. All this is best done internally in the MCLF code and has nothing to do with the valuation code. |
I see. But I feel that large parts of this are not specific to MCLF but that there is a point in improving the possibilities to define morphisms and in particular embeddings and isomorphisms of finite fields and function fields (or their isomorphic counterparts that are really missing such functionality, namely fields of fractions and quotient rings.) |
In this new version of reduction_trees, the maps between different components (inertial, lower and upper) are constructed in a systematic way and such that they are compatible with the maps of generic fibers. All components are created as curves over an *absolute* finite fields, thus fixing issue MCLF#103 and adressing in aprt issue MCLF#66. This is done by using the helper functions and `make_finite_fields` which turns a finite field into an absolute fielte, and `make_function_fields` which turns a function field into a 'true' function field over an absolute finite field. There should be more doctests and internal consistency test.
This merge fixes several bugs and started a reorganization of `reduction_trees` The key commit is 8844501: In this new version of reduction_trees, the maps between different components (inertial, lower and upper) are constructed in a systematic way and such that they are compatible with the maps of generic fibers. All components are created as curves over an *absolute* finite fields, thus fixing issue #103 and adressing in part issue #66. This is done by using the helper functions and `make_finite_fields` which turns a finite field into an absolute fielte, and `make_function_fields` which turns a function field into a 'true' function field over an absolute finite field. Once `trac:26103` is merged, these functions can probably be removed. I think a further reorganization of `reduction_trees` and, related to this, of `smooth_projective_curves` and `morphisms_of_smooth_projective_curves` is necessary, but this will do for a while.
It would be great if the residue field k of a discrete valuation v_K on a field K would more or less obey the following two rules:
I will now and then list instances in the MCLF code where this is not the case. There may also be examples where the two rules contradict each other.
TODO:
The text was updated successfully, but these errors were encountered: