You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is it possible for the $suit member to be of type Suit rather than type String? At the moment, I think the Suit class is just used as a place to store the array of suits. I’m thinking it should have a $name member (or perhaps $suitname) of type string, and then it could be used to provide a type to the member in PlayingCard. That’s the way we’ve done it in Java, but I don’t know if there’s a PHP reason not to do this 😃
Is it possible for the
$suit
member to be of type Suit rather than type String? At the moment, I think the Suit class is just used as a place to store the array of suits. I’m thinking it should have a$name
member (or perhaps$suitname
) of typestring
, and then it could be used to provide a type to the member inPlayingCard
. That’s the way we’ve done it in Java, but I don’t know if there’s a PHP reason not to do this 😃Originally posted by @mrmanc in #128 (comment)
If this change is made it might need to be applied to other branches which have the
Suit
class too.The text was updated successfully, but these errors were encountered: