Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS apprentices likely to need some guidance around how to write OO code in JS #78

Open
mrmanc opened this issue Mar 17, 2021 · 2 comments
Assignees
Labels
javascript Changes which involve JS please comment
Milestone

Comments

@mrmanc
Copy link
Member

mrmanc commented Mar 17, 2021

We should create some slides which describe an approach to doing this, and possibly give them some example code in the repo that they can refer to.

@mrmanc mrmanc added javascript Changes which involve JS please comment labels Mar 17, 2021
@helloheatherw
Copy link
Collaborator

Is this specifically related to the exercises? If so, I think it might be worth refactoring the existing starting code as it currently mixes up some new and old syntax, as well as using some non-idiomatic JS that I think caused some confusion.

For example, the starting code for the cards class uses the Class keyword, but also uses prototype syntax for declaring methods. It would also be useful to have this example use the constructor method.

I'm happy to put some thoughts on to PR if that would be helpful.

@helloheatherw helloheatherw self-assigned this Mar 18, 2021
@mrmanc
Copy link
Member Author

mrmanc commented Mar 18, 2021

Is this specifically related to the exercises?

No, I was thinking general case stuff to illustrate the syntax. I was thinking it would be good to show both approaches (but unmixed).

it might be worth refactoring the existing starting code

Sounds sensible. I’m not qualified to say what approach it should follow, but I like the idea of creating a PR and running it past some of the people who support other JS apprentices.

@mrmanc mrmanc added this to the Cohort Six milestone Nov 2, 2021
@mrmanc mrmanc modified the milestones: Cohort Six, May not need Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Changes which involve JS please comment
Projects
None yet
Development

No branches or pull requests

2 participants