Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check Java builds after clone #41

Open
mrmanc opened this issue May 27, 2021 · 5 comments
Open

Check Java builds after clone #41

mrmanc opened this issue May 27, 2021 · 5 comments
Assignees
@alectunbridge
Milestone
Cohort Seven

Comments

@mrmanc
Copy link
Member

mrmanc commented May 27, 2021

@alectunbridge experienced visibility problems around classes with default access. He had to make the classes public to resolve it.
@mrmanc
Copy link
Member Author

mrmanc commented Jan 27, 2022

@alectunbridge are you able to reproduce this?

@alectunbridge
Copy link
Collaborator

I presume this applies to the Tax Calculator code base - I've done a fresh fork and clone and cannot recreate, even though the classes still have default visibility 🤷

mrmanc added a commit that referenced this issue Jan 27, 2022
@mrmanc
Make name of file match the class
a53580f 
We don’t use this but it was causing compiler errors. This is possibly (but probably not) what #41 was referring to.
@mrmanc
Copy link
Member Author

mrmanc commented Jan 31, 2022

Had this problem again when I unignored the test. Making the three tax prod classes public resolved it. Screenshots in Slack.

@mrmanc mrmanc reopened this Jan 31, 2022
@mrmanc
Copy link
Member Author

mrmanc commented Jan 31, 2022

image
image
image

@mrmanc mrmanc added this to the Cohort Seven milestone Jan 31, 2022
@mrmanc
Copy link
Member Author

mrmanc commented Jan 31, 2022

Weirdly, I’ve just tried to reproduce this by checking out b040790 locally and was unable to. Might be worth trying with a fresh clone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alectunbridge alectunbridge

Labels
None yet
Projects
None yet
Milestone
Cohort Seven
Development

No branches or pull requests
2 participants
@mrmanc @alectunbridge