-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numpy to requirements.txt #39
Comments
I can't assign you for some reason @BFedder. |
I had added NumPy as required dependency as part of #33, and have now changed it to require the same version(s) as MDAnalysis |
This is now merged. However, with MDAnalysis moving to numpy>1.20, it might be worth to do the same here, but this would mean dropping Python3.6. Do we want to do that here? |
Imho no - MDA will enforce it's own subselection of numpy & python because it lives downstream. It's fine for panedr to support a wider range until it becomes absolutely necessary to restrict to a newer version. |
@hmacdope, are you happy for this issue to be closed now that numpy>1.19 is in requirements.txt? |
Yep all good! |
As discussed on #33, we can make NumPy a required dependency.
Probably best to use the same version as MDA.
The text was updated successfully, but these errors were encountered: