Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numpy to requirements.txt #39

Closed
hmacdope opened this issue Jun 23, 2022 · 6 comments
Closed

Add numpy to requirements.txt #39

hmacdope opened this issue Jun 23, 2022 · 6 comments

Comments

@hmacdope
Copy link
Member

As discussed on #33, we can make NumPy a required dependency.
Probably best to use the same version as MDA.

@hmacdope
Copy link
Member Author

I can't assign you for some reason @BFedder.

@BFedder
Copy link
Collaborator

BFedder commented Jun 25, 2022

I had added NumPy as required dependency as part of #33, and have now changed it to require the same version(s) as MDAnalysis

@BFedder
Copy link
Collaborator

BFedder commented Jun 29, 2022

This is now merged. However, with MDAnalysis moving to numpy>1.20, it might be worth to do the same here, but this would mean dropping Python3.6. Do we want to do that here?

@IAlibay
Copy link
Member

IAlibay commented Jun 29, 2022

Imho no - MDA will enforce it's own subselection of numpy & python because it lives downstream. It's fine for panedr to support a wider range until it becomes absolutely necessary to restrict to a newer version.

@BFedder
Copy link
Collaborator

BFedder commented Jul 4, 2022

@hmacdope, are you happy for this issue to be closed now that numpy>1.19 is in requirements.txt?

@hmacdope
Copy link
Member Author

hmacdope commented Jul 4, 2022

Yep all good!

@hmacdope hmacdope closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants