Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document "Unpublish Event" and "Publish Without Email" in the server synchronization settings #232

Open
cudeso opened this issue Mar 3, 2021 · 2 comments
Labels
T: enhancement Type: enhancement. This issue seeks an improvement of an existing feature

Comments

@cudeso
Copy link

cudeso commented Mar 3, 2021

Currently the settings under "Misc settings" are not fully documented.

  • Unpublish Event
    -> Works for pull events
  • Publish Without Email
    -> Works with push events
  • Self Signed
  • Skip proxy (if applicable)
@Wachizungu
Copy link
Contributor

Added things for everything.
Self signed was already there I think.

For unpublish event, I have the opposite as you in my tests though, it seems to work on push but not on pull and we actually count on this in our production environment. Can you please confirm for you it works only on pull? Honestly I tend to believe this is a bug in either case and should work in both situations. Will see if someone from core team comments here, if not I'll ask on gitter.

Publish without email I can't test myself as I don't have an instance with working email to test. Please let me know / double check if it only works on push, if so I'll add that. Again, that also sounds like a bug to me though.

Some other questions I have:

  • Does the push/pull galaxy clusters mean that you push/pull custom galaxy clusters? Or that you push/pull clusters related to the galaxy tags you sync or have synced.
  • Related to the above. Why is there a specific pull technique to pull in galaxy clusters, but the same does not exist for push? I'm guessing this might be because if the answer to the above question is 'you push/pull clusters related to the galaxy tags you sync or have synced.' having this option for push doesn't make much sense.
  • There is a checkbox to 'push sightings' but nothing for 'pull sightings', are sightings always pulled in or never?
  • If self signed is set, ssl_verify_peer_name is set to false as well (see https://github.com/MISP/MISP/blob/2.4/app/Lib/Tools/SyncTool.php#L25). I'm assuming this flag in essence says: 'whatever, I don't care, cert is okay even if the name doesn't match'. If that is correct I still have to change the text a bit.

@cudeso
Copy link
Author

cudeso commented Mar 29, 2021

Sorry for the late update.
In the versions >=2.4.139 it seems the "unpublish event" does not work on Pull.
Going to try your fix MISP/MISP#7199

@iglocska Will "unpublish be removed (as in MISP/MISP#7139 (comment))? I personally feel that unpublishing an event after pulling it in makes sense.

@enjeck enjeck added the T: enhancement Type: enhancement. This issue seeks an improvement of an existing feature label Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: enhancement Type: enhancement. This issue seeks an improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants