Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy not updating when the version number is not an increase of 1 #183

Open
Malwarebinary opened this issue Apr 1, 2020 · 0 comments
Labels
help wanted This is an issue that community can help with T: bug Type: bug report: This issue describes unexpected behaviour

Comments

@Malwarebinary
Copy link

Malwarebinary commented Apr 1, 2020

Hey MISP crew,

I encountered this issue while trying to update an internal taxonomy. We used to increase the taxonomy version number by 0.1. For instance, my last version was 2.5 and my new version 2.6. When uploading the taxonomy (machinetag.json) file in the server -> update taxonomies from the UI, the taxonomy was not updated. I validate the taxonomy json file using the script machinetag.py but everything was fine. Later, I realize that the taxonomy number is rounded up when looking at the taxonomy description from the UI.

image

image

Then, I changed the version number to 4, updated the taxonomies again and boom it worked ! It seems that MISP is performing a round operation on the version number so I was getting version 3 for 2.5 and 2.6. Because the version number was the same, the taxonomy was not updated. Maybe adding a note about that in the project would help or simply accept decimal number for the version number.

Thanks !

@enjeck enjeck added T: enhancement Type: enhancement. This issue is not a bug, it improves an existing feature help wanted This is an issue that community can help with T: bug Type: bug report: This issue describes unexpected behaviour and removed T: enhancement Type: enhancement. This issue is not a bug, it improves an existing feature labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted This is an issue that community can help with T: bug Type: bug report: This issue describes unexpected behaviour
Projects
None yet
Development

No branches or pull requests

2 participants