Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker-build-test.yml github workflow fails with "docker-compose: command not found" #2268

Closed
tompollard opened this issue Aug 6, 2024 · 2 comments
Closed

docker-build-test.yml github workflow fails with "docker-compose: command not found" #2268

tompollard opened this issue Aug 6, 2024 · 2 comments

Comments

@tompollard
Copy link
Member

tompollard commented Aug 6, 2024 •
edited
Loading

As discussed in #1951 the docker-build-test.yml github workflow fails with a "docker-compose: command not found" message.

See for example: https://github.com/MIT-LCP/physionet-build/actions/runs/10268369632?pr=1951.

Run docker-compose -f docker/docker-compose.test.yml run --rm test
/home/runner/work/_temp/edb7259f-2285-[4](https://github.com/MIT-LCP/physionet-build/actions/runs/10268369632/job/28415632700?pr=1951#step:5:5)28f-9fea-e0d29c68fbc1.sh: line 1: docker-compose: command not found
Error: Process completed with exit code 127.

I'm not aware of any changes on our side that would have triggered this error. I assume that the cause is either (1) temporary glitch (e.g. with Docker) or (2) ubuntu-latest isn't what it used to be. Probably 2 I think.
@tompollard
Copy link
Member Author

Looks like this might be the cause: https://docs.docker.com/compose/migrate/

Update scripts to use Compose V2 by replacing the hyphen (-) with a space, using docker compose instead of docker-compose.

@tompollard tompollard mentioned this issue Aug 6, 2024
Merged
tompollard added a commit that referenced this issue Aug 6, 2024
@tompollard
docker-compose -> docker compose (#2269)
a975a6c 
We are seeing a new "`docker-compose: command not found`" error on the
[docker-build-test.yml github
workflow](https://github.com/MIT-LCP/physionet-build/blob/dev/.github/workflows/docker-build-test.yml).
See: #2268

It looks like "`docker-compose`" is being phased out, in favour of
"`docker compose`":
https://docs.docker.com/compose/migrate/. This pull request switches all
mentions to `docker-compose` to `docker compose`.

Merging this pull request should fix the error in:
#1951
@tompollard
Copy link
Member Author

fixed in #2269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tompollard