Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Wyscout API v3 #156

Open
probberechts opened this issue Jan 7, 2022 · 5 comments
Open

Add Support for Wyscout API v3 #156

probberechts opened this issue Jan 7, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@probberechts
Copy link
Member

On July 20th 2021, Wyscout switched their API to v3. Currently, socceraction only supports v2 of the Wyscout API, which is now a legacy version. Adding support for the new API format will require substantial changes to the socceraction.data.wyscout and socceraction.spadl.wyscout modules. As v2 of the API will remain available until the release of v4 (no release date yet), making these changes is currently not a priority. However, pull requests would be welcome.

See https://apidocs.wyscout.com/ for details.

@probberechts probberechts added the enhancement New feature or request label Feb 16, 2023
@lucyrowland
Copy link

I'm running into issues where the v2 endpoint doesn't have event data for matches whereas the v3 endpoint does.

@probberechts
Copy link
Member Author

Currently, I do not plan to implement support for v3 myself.

@mjam03
Copy link

mjam03 commented Jan 24, 2024

hi there - does the wyscout v2 version currently work for conversion to SPADL or are there known issues?

was curious about how the package worked so had a look around earlier and wanted to understand if SPADL should produce the same quantity of events regardless of provider and ended up with:

  • ~1500 from otpa
  • ~1300 from wyscout v2

(i don't have opta access but dug out the match events xml from the tests folder as another data provider sense check)

is this expected? or does this mean there are existing issues in either the opta-to-spadl process or wyscoutv2-to-spadl process?

keen to understand so i can try to get involved with known wyscout issues

@probberechts
Copy link
Member Author

@mjam03 Great question! The quantity of events will differ between providers because each provider uses different definitions and they always make a few mistakes. The main events like shots, free-kicks, etc. should be identical. But there might be some differences in the number of take-ons vs dribbles and even the number of passes will often be slightly different.

@mjam03
Copy link

mjam03 commented Jan 29, 2024

okay great - i think i’ll have a bit of a look at the wyscout v3 stuff and if i get something sorted will make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants