Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only some users are able to teleport leashed/ridden animals with them #93

Open
QuantumToasted opened this issue Oct 11, 2020 · 3 comments

Comments

@QuantumToasted
Copy link

Not sure if this is a bug or a permissions thing I'm missing, but most users on my server are unable to teleport the horse they're riding or any mobs on a lead. Is there a permission node responsible for this? Or a bug? I have all permissions and it works for me but I...haven't tested removing the permissions from myself, but I could not find a node that made sense with autocomplete or looking at the nodes themselves. I'm the only one absolutely confirmed that it works for (the owner and have * permissions set), but another user has reported it working for them before but with no video evidence.

@zedwick
Copy link
Collaborator

zedwick commented Oct 11, 2020

Last time I looked into this I think I concluded that when using the LaunchAndDropPlayers animation, the player would be moved away from the horse/mob which would move them out of range to be considered for teleport, or otherwise could break the leash connection required for teleport. So one potentially easy fix would be to set LaunchAndDropPlayers to false in your config, if you have it enabled.

The player is currently simply kicked off the horse prior to teleporting, so they would need to leash the horse to bring it with them when they teleport.

@QuantumToasted
Copy link
Author

That did seem to do the trick for the time being, considering LaunchAndDropPlayers is mostly cosmetic, it's not much of a bother. Might not be a bad idea to look into doing the leashed animal check before flinging them into the air. I'm not sure why it only worked for me, if latency somehow affects the check's accuracy in some way. I was connected via localhost instead of the public IP so I obviously had essentially no latency.

The dev is welcome to close this issue if it's considered a wontfix because the solution is easily solved by not launching players into the air before teleporting, but if they'd like to look into this I'll keep it open.

@zedwick
Copy link
Collaborator

zedwick commented Oct 23, 2020

Might not be a bad idea to look into doing the leashed animal check before flinging them into the air.

This would be the way to go. I wanted to rewrite the whole teleport code, as I think it has a few other issues mainly around bringing animals. Teleporting all nearby animals generally seems to cause players grief when they happen to keep animals near the region post, which are then taken with visitors to their own regions. It would probably be best to make sure animals are intentionally brought with the player by only taking leashed or ridden entities. Unfortunately I've not found the time to pick it apart yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants