Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark message as read item on tapped notification item including time-passed/completed observation! #225

Open
alireza-dhp opened this issue Feb 23, 2024 · 4 comments · Fixed by #236
Labels
bug Something isn't working medium priority

Comments

@alireza-dhp
Copy link
Member

It is ideal to mark the notification message as read when a user taps on a notification including time-passed/completed observation.
This functionality is available when user taps on a simple notification message!

@alireza-dhp alireza-dhp added bug Something isn't working medium priority labels Feb 23, 2024
@andresgruber
Copy link
Contributor

Dear @alireza-dhp : Please clarify this issue:

There is a bug on iOS ? and/or on Android? (version ?) with not marking action notifications as unread by tapping on it (from the notification center of the mobile? from the notification page within the app?)

And the required behaviour is not entirely clear to me:

Is it: "Every tap on a notification message (irrespective whether its a simple notification or a action notification), from within the notification page of the app should mark the notification as read" ?

@alireza-dhp
Copy link
Member Author

Dear @andresgruber,

The issue has been identified on iOS (version 3.0.8, redlink-staging branch) within the app's notification page.
The intended behavior is that when a user taps (for the first time) on an action notification where the corresponding observation has already been completed or time has passed, the message status should change to "read" (disappearing the red bolt point is intended).
Currently, on iOS, tapping these notifications navigates to the observation details (which is fine), but the message status remains unread (the red bolt point is displayed).

The current behavior is accurate for simple notifications and action notifications where the corresponding observation has not been finished or time has not elapsed.

I am currently unable to test this on Android as tapping on Action Notifications is not functional on that platform (refer to: #221 (comment)). However, it is crucial to ensure that the same functionality is implemented on Android once the issue is resolved for iOS.

Please let me know if you need further description.

@alireza-dhp
Copy link
Member Author

Dear @andresgruber,
We have this issue on Android as well.
I tested it after version 3.0.10 was released.

@alireza-dhp
Copy link
Member Author

Dear @janoliver20, @andresgruber

Thank you for addressing the issue.

Regarding PR #236, one recommendation is that when a participant taps on an action notification that has been passed but not completed, instead of indicating it with a green tick (which might imply the participant filled in the observation), it could be labeled as "read" only. (In this scenario, the intention is to remove the red bullet point.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium priority
Projects
Development

Successfully merging a pull request may close this issue.

2 participants