Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly improved performance of cuminc #95

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

pteridin
Copy link
Contributor

@pteridin pteridin commented Jul 14, 2023

What changes are proposed in this pull request?

Significantly improved performance of cuminc due to replacing the for-loop and restructuring the re-encoding of the events.

If there is an GitHub issue associated with this pull request, please provide link.

closes #73

Checks

Output was tested on smaller datasets with and without strata and yields identical output as far as I can tell.


Checklist for PR reviewer

  • PR branch has pulled the most recent updates from master branch. Ensure the pull request branch and your local version match and both have the latest updates from the master branch.
  • If a new function was added, function included in _pkgdown.yml
  • If a bug was fixed, a unit test was added for the bug check
  • Run pkgdown::build_site(). Check the R console for errors, and review the rendered website.
  • Code coverage is suitable for any new functions/features. Review coverage with covr::report(). Before you run, set Sys.setenv(NOT_CRAN="true") and begin in a fresh R session without any packages loaded.
  • R CMD Check runs without errors, warnings, and notes
  • usethis::use_spell_check() runs with no spelling errors in documentation

When the branch is ready to be merged into master:

  • Update NEWS.md with the changes from this pull request under the heading "# tidycmprsk (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end of the update.
  • Increment the version number using usethis::use_version(which = "dev")
  • Run usethis::use_spell_check() again
  • Approve Pull Request
  • Merge the PR. Please use "Squash and merge".

…r-loop and restructuring the re-encoding of the events.
@pteridin
Copy link
Contributor Author

devtools::test()

══ Results ══════════
Duration: 23.6 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 99 ]

@ddsjoberg ddsjoberg self-requested a review July 24, 2023 17:13
@ddsjoberg
Copy link
Collaborator

@pteridin big thank you for the update!! MUCH MUCH appreciated!! ❤️

@ddsjoberg ddsjoberg merged commit fd7f2ed into MSKCC-Epi-Bio:main Oct 26, 2023
1 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cuminc() very slow on larger data set
2 participants