Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node version 12 #50

Open
RouR opened this issue Feb 18, 2021 · 3 comments
Open

node version 12 #50

RouR opened this issue Feb 18, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@RouR
Copy link

RouR commented Feb 18, 2021

npm install ngx-onesignal

node: 14.15.4
Wanted node version 12 (>=12.0.0 <13.0.0)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] preinstall: `npx check-node-version --node 12`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] preinstall script.

Is it really need restrict node version to 12?

@RouR
Copy link
Author

RouR commented Feb 18, 2021

Same question for OS restrictions.

npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

@MSakamaki MSakamaki self-assigned this Feb 18, 2021
@MSakamaki MSakamaki added the bug Something isn't working label Feb 18, 2021
@MSakamaki
Copy link
Owner

@RouR Thanks for the report! this is a bug.

It supports node v 12 and above, so it should work with 14.
I will update the package soon.

@MSakamaki
Copy link
Owner

MSakamaki commented Feb 18, 2021

@RouR I have confirmed that it works with the latest node versions. ( [email protected]
However, since angular version 11 is not yet supported, we had to do the following

npx @angular/cli@10 new [project name]
npx ng add @angular/pwa
npx ng add ngx-onesignal --appId=XXXxX

Angular 11 support will be released in the near future.
sorry wait for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants